Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Windows input operator leaks remote session handle #35577

Closed
kuiperda opened this issue Oct 3, 2024 · 3 comments · Fixed by #35696
Closed

[pkg/stanza] Windows input operator leaks remote session handle #35577

kuiperda opened this issue Oct 3, 2024 · 3 comments · Fixed by #35696
Assignees
@VihasMakwana
Labels
bug Something isn't working os:windows pkg/stanza

Comments

@kuiperda
Copy link
Contributor

kuiperda commented Oct 3, 2024

Component(s)

pkg/stanza

What happened?

Description

@pjanotti noticed this here (#35520)

Steps to Reproduce

See the comment above. Since Subscription::Close does not close the remote session handle, it is leaked. This will happen when the operator resubscribes due to the remote host restarting, for example.

Expected Result

The remote session handle should be closed properly so it does not get leaked.

Actual Result

Collector version

v0.110.0

Environment information

N/A

OpenTelemetry Collector configuration

N/A

Log output

N/A

Additional context

N/A
@kuiperda kuiperda added bug Something isn't working needs triage New item requiring triage labels Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@VihasMakwana
Copy link
Contributor

VihasMakwana commented Oct 3, 2024 •
edited
Loading

Based on #35520 (comment), it seems as @kuiperda wouldn't have time to work on this.

I will have a crack at this though. @djaglowski can you assign this to me?

@crobert-1
Copy link
Member

Removing needs triage as a triager pointed out this issue.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 3, 2024
@github-actions github-actions bot mentioned this issue Oct 8, 2024
Closed
@VihasMakwana VihasMakwana mentioned this issue Oct 8, 2024
Merged
djaglowski pushed a commit that referenced this issue Oct 14, 2024
@VihasMakwana
[stanza/input/windows]: fix remote session leak while resubscribing (#…
0a6bb8a 
…35696)

Stop the remote session before starting a new one while resubscribing.

Closes
#35577
whitneygriffith pushed a commit to whitneygriffith/opentelemetry-collector-contrib that referenced this issue Oct 14, 2024
@VihasMakwana @whitneygriffith
[stanza/input/windows]: fix remote session leak while resubscribing (o…
f7be7fd 
…pen-telemetry#35696)

Stop the remote session before starting a new one while resubscribing.

Closes
open-telemetry#35577
jmichalek132 pushed a commit to jmichalek132/opentelemetry-collector-contrib that referenced this issue Oct 14, 2024
@VihasMakwana @jmichalek132
[stanza/input/windows]: fix remote session leak while resubscribing (o…
bee5e1a 
…pen-telemetry#35696)

Stop the remote session before starting a new one while resubscribing.

Closes
open-telemetry#35577
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@VihasMakwana @sbylica-splunk
[stanza/input/windows]: fix remote session leak while resubscribing (o…
163087b 
…pen-telemetry#35696)

Stop the remote session before starting a new one while resubscribing.

Closes
open-telemetry#35577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VihasMakwana VihasMakwana

Labels
bug Something isn't working os:windows pkg/stanza
Projects
None yet
Milestone
No milestone
3 participants
@kuiperda @crobert-1 @VihasMakwana