Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go 1.20 for official builds #286

Closed
mx-psi opened this issue Feb 8, 2023 · 3 comments · Fixed by #321
Closed

Switch to Go 1.20 for official builds #286

mx-psi opened this issue Feb 8, 2023 · 3 comments · Fixed by #321
Labels
go Pull requests that update Go code good first issue Good for newcomers priority:p2

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 8, 2023

Go 1.20 was released recently: https://go.dev/doc/go1.20

After we add testing for it on core (open-telemetry/opentelemetry-collector/issues/7159) and contrib (open-telemetry/opentelemetry-collector-contrib/issues/18454) we can switch to using the Go 1.20 compiler for official builds. Based on historical precedent this will make our life easier when dealing with security issues since we don't depend on the Go team backporting fixes and can react more quickly.

@mx-psi mx-psi added go Pull requests that update Go code priority:p2 labels Feb 8, 2023
@jpkrohling
Copy link
Member

This might even make our lives easier during the release, as we seem to have dependencies requiring 1.20 already (cc @codeboten)

@mx-psi
Copy link
Member Author

mx-psi commented Feb 8, 2023

I think all components on contrib should still support building with Go 1.19 per our compatibility rules, so I don't think this is a solution to that problem (although I am not aware of the specific problem). One option is to provide functionality (the one that uses those dependencies) conditionally only when building with a Go 1.20+ compiler (via the go1.20 build tag)

@mx-psi
Copy link
Member Author

mx-psi commented Feb 15, 2023

This is now unblocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code good first issue Good for newcomers priority:p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants