Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move back to latest for goreleaser #668

Closed
mx-psi opened this issue Sep 19, 2024 · 17 comments · Fixed by #737
Closed

Move back to latest for goreleaser #668

mx-psi opened this issue Sep 19, 2024 · 17 comments · Fixed by #737
Assignees
Labels
bug Something isn't working

Comments

@mx-psi
Copy link
Member

mx-psi commented Sep 19, 2024

Because of goreleaser/goreleaser/issues/5138, CI is currently broken when using goreleaser v2.3.0+.

#667 fixes this temporarily for the next release

@dosubot dosubot bot added the bug Something isn't working label Sep 19, 2024
@jade-guiton-dd
Copy link
Contributor

jade-guiton-dd commented Oct 4, 2024

Are we sure we want to move back to latest instead of upgrading the version periodically? Manually upgrading would prevent the CI unexpectedly breaking on main like it did twice already.

@mx-psi
Copy link
Member Author

mx-psi commented Oct 4, 2024

Could we automate the bumping? For other stuff like Github Actions we use dependabot/renovate bot, but here I don't think there is an equivalent tool that is ready for this. Maybe we can ask upstream on the goreleaser repositories for advice?

@mowies
Copy link
Member

mowies commented Oct 16, 2024

it would be possible with renovate i believe. maybe with some additional config to cover all occurrences, but it should be possible

@mx-psi
Copy link
Member Author

mx-psi commented Oct 16, 2024

@mowies Do you have any links/examples explaining how this would be done with renovate?

@mowies
Copy link
Member

mowies commented Oct 17, 2024

Something like this should work with renovate. It's a custom regex manager that matches the goreleaser action's input for the version. It could probably be done a little nicer and more resilient but it should work I think.

    {
      "fileMatch": [
        "(^|\\/).github\\/.*\\.ya?ml$"
      ],
      "matchStrings": [
        "goreleaser\\/goreleaser-action@[\\S\\s]+version: (?<currentValue>.*?)$"
      ],
      "depName": "github.com/goreleaser/goreleaser",
      "datasourceTemplate": "github-releases"
    }

@mowies
Copy link
Member

mowies commented Oct 17, 2024

@mx-psi if you could take care of setting up renovate in this repo (or tell me what to do), then i'd be happy to contribute the needed config changes :)

@mx-psi
Copy link
Member Author

mx-psi commented Oct 17, 2024

I believe you will have to file an issue similar to this one: open-telemetry/community/issues/1792 but for this repository. I am happy to voice my support in such an issue.

@mowies
Copy link
Member

mowies commented Oct 17, 2024

Cool! I filed the issue: open-telemetry/community#2403

@mowies
Copy link
Member

mowies commented Oct 28, 2024

i will work on this when the renovate PR is merged, pls assign to me :)

@mx-psi
Copy link
Member Author

mx-psi commented Oct 28, 2024

Done!

@mowies
Copy link
Member

mowies commented Nov 6, 2024

PR is open for this: #728

@mowies
Copy link
Member

mowies commented Nov 11, 2024

seems like the regex I added still has some issues. I'll do a follow up PR

@mowies
Copy link
Member

mowies commented Nov 12, 2024

@mx-psi maybe this PR fixes it: #733

@mx-psi
Copy link
Member Author

mx-psi commented Nov 18, 2024

Was this fixed by #733?

@mowies
Copy link
Member

mowies commented Nov 18, 2024

unfortunately not, but i pivoted to test everything on my own fork with renovate activated there, so the next one will stick 😅

@mowies
Copy link
Member

mowies commented Nov 19, 2024

Ok I think I fixed it now :)
#737

@mowies
Copy link
Member

mowies commented Nov 20, 2024

Screenshot 2024-11-20 at 12 34 03
looks like this is actually solved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants