Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PIE buildmode setup #771

Open
mowies opened this issue Dec 11, 2024 · 1 comment
Open

Refactor PIE buildmode setup #771

mowies opened this issue Dec 11, 2024 · 1 comment

Comments

@mowies
Copy link
Member

mowies commented Dec 11, 2024

During my time in rebase-hell for #762 after #726 was merged, I noticed that the PIE buildmode setup with duplicated builds with lots of ignored arch/os combinations could be simplified a lot with a different approach:

Instead of using build combinations to encode the compatible architectures where PIE binaries are possible, it can be encoded into a templated environment variable similar to what is described here in the goreleaser docs. That env variable could then be used directly in the ldflags like is done here to get the same result without the need to duplicate builds.

cc @jackgopack4

@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2024

This makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants