-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collector Shutdown should block until Run cleans up #4947
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Good issue for contributors to OpenTelemetry Service to pick up
priority:p2
Medium
Comments
@djaglowski said it can be upstreamed |
bogdandrutu
added
help wanted
Good issue for contributors to OpenTelemetry Service to pick up
good first issue
Good for newcomers
labels
Apr 8, 2022
Can I work on this? |
@deepto98 sure. Assigned to you. Thanks |
Hi @deepto98, are you still working on this? I would like to take this up |
Hi @cpheps I guess 1 and 2 has been addressed by other the other issues |
going to take a look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Good issue for contributors to OpenTelemetry Service to pick up
priority:p2
Medium
Is your feature request related to a problem? Please describe.
Discussion from 4878 led to a decision to design
Shutdown
to follow language patterns for how it andRun
should operate. Followinghttp.Server
as an example the following behaviors should be met:Shutdown
be safe to be called at any point. Even if there is no action to takeShutdown
is called beforeRun
it will exit cleanly and the next call toRun
will exit due to the previousShutdown
Shutdown
is called whileRun
is active it should block untilRun
has confirmed shutdown.Point 3 isn't currently implemented but desired behavior.
Describe the solution you'd like
Shutdown
will block untilRun
has confirmed cleanup. WhateverShutdown
checks for should not stop it from cleanly exiting ifRun
hasn't been called yet or afterRun
was called.Describe alternatives you've considered
Alternative is don't block
Shutdown
and just exit like it does now after closing the channel.Additional context
Action item from #4878
If we want to go this route I think there needs to be some discussion on what
Shutdown
should block on. It seems like it should be when the state isClosing
but that won't allowShutdown
to cleanly exit if called before or afterRun
.The text was updated successfully, but these errors were encountered: