Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Build on 386 architecture #5031

Closed
mx-psi opened this issue Mar 17, 2022 · 7 comments · Fixed by #5142
Closed

[CI] Build on 386 architecture #5031

mx-psi opened this issue Mar 17, 2022 · 7 comments · Fixed by #5142
Assignees
Labels
ci-cd CI, CD, testing, build issues good first issue Good for newcomers priority:p1 High

Comments

@mx-psi
Copy link
Member

mx-psi commented Mar 17, 2022

We don't build on 386 architecture on CI, but we do release 386 binaries for this distro. This means that if there is an issue like #5013 (comment), we don't detect it until potentially the very last step of the release.

We can add builds for Windows 386 and Linux 386 to CI on this repository to catch these build errors sooner.

Edit: As discussed below, this also applies to arm64 and any other OS-architecture pair that we intend to release

@Aneurysm9
Copy link
Member

Do we need to do the same for ARM?

@mx-psi
Copy link
Member Author

mx-psi commented Mar 17, 2022

Do we need to do the same for ARM?

Yes, I thought we were doing it already, but maybe we are doing it only on contrib. We should build on every arch-OS combination that we intend to do an official release of.

@dmitryax dmitryax added the priority:p1 High label Mar 18, 2022
@codeboten
Copy link
Contributor

As discussed at triage on Mar-18, the real problem here is that there's a delta between what we're testing for every build vs what we're releasing.

@hickeyma
Copy link
Contributor

hickeyma commented Apr 4, 2022

@mx-psi Investigating this, it would seem that GitHub actions hosted runners only supports the x86_64/AMD64 processor architecture. ARM64 Linux issue was opened but closed as not supported. The limitation is the VMs on Azure used for hosted runners.

Workarounds are :

@mx-psi
Copy link
Member Author

mx-psi commented Apr 4, 2022

@hickeyma You can cross-compile just by setting the GOOS=<os value> and GOARCH=<arch value> environment variables, regardless of the host architecture. Since we don't use cgo this should work out of the box without needing to install anything else. You won't be able to run the resulting binaries (or do go test) but just for checking that it builds it would be good enough.

@hickeyma
Copy link
Contributor

hickeyma commented Apr 4, 2022

@mx-psi Thanks for the feedback. I mis-read the requirement. That simplifies it.

Pushed #5142 for adding the GitHub actions job.

@hickeyma
Copy link
Contributor

hickeyma commented Apr 4, 2022

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues good first issue Good for newcomers priority:p1 High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants