[OtelMetrics] Counters have a suffix "_total"

[bogdandrutu]

This is according to the Prometheus specs, but inconsistent with what was there before. We need to check that metrics scraped by otel/collector prometheus receiver remove this suffix and we are good then, otherwise this is a breaking change.

[bogdandrutu]

See https://github.com/open-telemetry/opentelemetry-collector/pull/6401/files

[paivagustavo]

@bogdandrutu tried this out today, and the prometheus receiver doesn't remove neither unit or type suffixes. Otel-go has an option to disable the units suffixes (_bytes, _ratio and _milliseconds) but not the type suffixes (_total).

There is an open ticket on the contrib repo tracking this open-telemetry/opentelemetry-collector-contrib#8950. I'll try to make some time this week or the next to work on that.

[paivagustavo]

#6559 addresses the unit suffixes: _bytes, _ratio and _milliseconds

open-telemetry/opentelemetry-collector-contrib#16071 addresses the type suffixes: _total

[codeboten]

This was addressed some time ago, closing