-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Limiter processor should be configurable to drop the data. #7699
Comments
What response would you expect the OpenTelemetry Collector to return to the Kong's Zipkin plugin in such case? A Is using the Kong OpenTelemetry plugin instead of the Zipkin plugin an option? |
Yes
Sadly currently we are not using Kong 3.x version, hence cannot use the above. |
That's fair, thanks for the explanation. Can you share your collector configuration (simplified if possible)? I'm assuming you are using the Zipkin receiver, is this correct? The Zipkin receiver indeed always returns the |
This seems to be a wider problem that is currently not solved, here's the open issue: and more specifically for OTLP receiver: The Zipkin receiver suffers from the same issue. |
Yes, we are using Zipkin receiver. Thanks a lot, @astencel-sumo for sharing similar issues. I see this issue has been discussed considerably and multiple receivers are not strictly implemented according to the receiver's API contract. I will see if I can fix this issue in the Zipkin receiver. |
Is your feature request related to a problem? Please describe.
We use Kong API gateway 2.8x and its Zipkin plugin to export traces. Unfortunately, this Zipkin plugin uses a batch queue with no max size limit (i.e. we can't specify the max number of batches that can be queued before the oldest batch is dropped when a new one is queued).
So in case, Otel-collector is overloaded (the batch queue is full), the memory limiter would refuse the data and the source(sender: Zipkin plugin) would retry sending the same batch. This will put pressure on the source.
Describe the solution you'd like
There should be a configurable option such that the memory limiter simply drops data instead of refusing it so that the sender does not receive backpressure.
The text was updated successfully, but these errors were encountered: