Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Define featuregates in metadata.yaml #9860

Open
dmitryax opened this issue Mar 27, 2024 · 4 comments
Open

[mdatagen] Define featuregates in metadata.yaml #9860

dmitryax opened this issue Mar 27, 2024 · 4 comments
Assignees
Labels
area:featuregate cmd/mdatagen enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@dmitryax
Copy link
Member

dmitryax commented Mar 27, 2024

We can define feature gates in the metadata.yaml and generate code + documentation from it. We can use the following YAML structure with a docker stats feature gate as an example:

feature_gates:
  - id: receiver.dockerstats.useScraperV2
    description: |
      When enabled, the receiver will use the function ScrapeV2 to collect metrics. 
      This allows each metric to be turned off/on via config. 
      The new metrics are slightly different to the legacy implementation.
    from_version: 0.60.0
    to_version: 0.74.0
    stage: stable
    reference_url: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/9794
@dmitryax dmitryax added enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up area:featuregate labels Mar 27, 2024
@mx-psi
Copy link
Member

mx-psi commented Mar 27, 2024

Duplicate of open-telemetry/opentelemetry-collector-contrib/issues/21801? We can keep both open I guess, since mine is more specific about each component that would need changes

@dmitryax
Copy link
Member Author

Duplicate of open-telemetry/opentelemetry-collector-contrib#21801? We can keep both open I guess, since mine is more specific about each component that would need changes

Right. I wasn't aware of that issue, sorry. We can use that one for making use of this feature and this one for introducing the capability itself.

@lavishpal
Copy link
Contributor

@dmitryax Could you assign this issue to me and it will be helpful if you provide guidance on how to get started?

@narcis96
Copy link
Contributor

narcis96 commented Oct 15, 2024

As discussed with @mx-psi, I am taking care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:featuregate cmd/mdatagen enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

5 participants