Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed strategy for making the collector an observable application #7532

Open
4 of 5 tasks
codeboten opened this issue Apr 12, 2023 · 3 comments
Open
4 of 5 tasks
Assignees
Labels
release:required-for-ga Must be resolved before GA release

Comments

@codeboten
Copy link
Contributor

codeboten commented Apr 12, 2023

This is a follow up to various conversations that have been had around this topic. I'd like to propose that we make the configuration for the collector follow the proposed configuration for SDKs (which is still under work, see sample configuration from the otep). Ideally I'd like to use the collector as a prototype of the configuration as it evolves.

I propose that most of the configuration parsing be done inside the collector for the time being, with the plan to leverage the Go SDK's implementation in the future. In order for this to work, there is quite a bit of work that needs to happen:

Related issues:
#6629
#7223

@codeboten codeboten self-assigned this Apr 12, 2023
@mattsains
Copy link
Contributor

Hello, I am interested in helping on this initiative, specifically exporting internal spans. Please let me know what I can do.

For my own testing, I have been writing a hacky extension which registers itself as a span processor for internal traces, converts the sdk span to a ptrace span, and exports it over otlp. However, I think it would be nice to work on a more official feature which could help others as well.

@mattsains
Copy link
Contributor

I think it would be worth adding a new issue here, for being able to turn off the existing telemetry metrics prometheus endpoint. Because even if you use the new export functionality for metrics, the collector still tries to open a prometheus port, and this behaviour cannot be disabled (only relocated to a different port). This causes problems if you try to run two collector instances on the same host

@kasun-bandara
Copy link

Hello, I am interested in helping on this initiative, specifically exporting internal spans. Please let me know what I can do.

For my own testing, I have been writing a hacky extension which registers itself as a span processor for internal traces, converts the sdk span to a ptrace span, and exports it over otlp. However, I think it would be nice to work on a more official feature which could help others as well.

Do we have the official processor support for internal traces/metrics yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga Must be resolved before GA release
Projects
Status: In Progress
Development

No branches or pull requests

5 participants