Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics SDK: Add MetricsReader #1091

Closed
lalitb opened this issue Nov 22, 2021 · 4 comments · Fixed by #1241
Closed

Metrics SDK: Add MetricsReader #1091

lalitb opened this issue Nov 22, 2021 · 4 comments · Fixed by #1241
Assignees
@esigo
Labels
area:sdk do-not-stale metrics
Milestone
Metrics SDK - Alp...

Comments

@lalitb
Copy link
Member

lalitb commented Nov 22, 2021 •
edited
Loading

The MetricReader handles collecting metrics from all SDK instruments. It also handles shutdown and force flush signals from the SDK.

Methods:

  • Collect
  • Shutdown
  • Periodic exporting MetricReader
    • collects metrics based on a user-configurable time interval and passes the metrics to the configured Exporter
@lalitb lalitb self-assigned this Nov 22, 2021
@lalitb lalitb added this to the Metrics SDK prototype milestone Nov 22, 2021
@lalitb lalitb removed their assignment Nov 22, 2021
@lalitb
Copy link
Member Author

lalitb commented Nov 23, 2021

@esigo - I realize this issue would need interfaces created as part of #1088, #1089, #1090. I am planning to make them available in a couple of days. Would suggest you pick this up once that is ready.

@lalitb lalitb changed the title Metrics SDK: Add MetricReader Metrics SDK: Add MeterReader Nov 30, 2021
@lalitb lalitb changed the title Metrics SDK: Add MeterReader Metrics SDK: Add MetricsReader Nov 30, 2021
@esigo
Copy link
Member

esigo commented Nov 30, 2021

@lalitb could you please assign this issue to me?
thanks

@lalitb
Copy link
Member Author

lalitb commented Nov 30, 2021

Sorry for the delay on #1088 and #1089 on which this has a dependency, will make them available this week.

@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Jan 30, 2022
@lalitb lalitb added do-not-stale and removed Stale labels Jan 30, 2022
@esigo esigo mentioned this issue Feb 6, 2022
Merged
3 tasks
@lalitb lalitb mentioned this issue Mar 3, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esigo esigo

Labels
area:sdk do-not-stale metrics
Projects
None yet
Milestone
Metrics SDK - Alpha release
Development

Successfully merging a pull request may close this issue.

Enable metric collection from MetricReader lalitb/opentelemetry-cpp
2 participants
@lalitb @esigo