Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gmock/gtest depepdency from ext::http::client::nosend #1226

Closed
lalitb opened this issue Feb 19, 2022 · 3 comments · Fixed by #1811
Closed

Remove gmock/gtest depepdency from ext::http::client::nosend #1226

lalitb opened this issue Feb 19, 2022 · 3 comments · Fixed by #1811
Assignees
Labels
bug Something isn't working do-not-stale

Comments

@lalitb
Copy link
Member

lalitb commented Feb 19, 2022

As discussed here, it would be good to remove gmock/gtest dependency from ext::http::client::nosend.

One option could be - We do plan to modify EventHandler::OnEvent to return the client implementation data at various phases of http(s) request handling if we can use that to return the Request object and validate for tests.

@lalitb lalitb added the bug Something isn't working label Feb 19, 2022
@esigo esigo self-assigned this Feb 19, 2022
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Apr 21, 2022
@owent
Copy link
Member

owent commented Apr 21, 2022

Also, nosend shoube be installed when using cmake.

@github-actions github-actions bot removed the Stale label Apr 22, 2022
@github-actions
Copy link

This issue was marked as stale due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-not-stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants