Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge async-changs #1412

Closed
owent opened this issue May 20, 2022 · 0 comments · Fixed by #1413
Closed

Merge async-changs #1412

owent opened this issue May 20, 2022 · 0 comments · Fixed by #1413

Comments

@owent
Copy link
Member

owent commented May 20, 2022

Is your feature request related to a problem?
The first version of async APIs of traces and logs is finished.We can merge these changes now and continue to work on more async implements for OtlpGrpc*Exporter or thread pool for curl::HttpClient.

Describe the solution you'd like

git reset --hard main
git merge --squash async-changes
git commit -m "Merge all commits from `async-changes`"

And the create PR from this commit to main .

Describe alternatives you've considered

git reset --hard main
git merge async-changes

Additional context

With --squash, we will merge all commits in async-changes into one but keep the history of main clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant