Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter emits target_info metric using Resource #1842

Closed
dashpole opened this issue Dec 5, 2022 · 1 comment · Fixed by #2301
Closed

Prometheus exporter emits target_info metric using Resource #1842

dashpole opened this issue Dec 5, 2022 · 1 comment · Fixed by #2301
Assignees
Labels
area:exporter:prometheus Prometheus Exporter area:metrics OpenTelemetry metrics do-not-stale

Comments

@dashpole
Copy link
Contributor

dashpole commented Dec 5, 2022

From the spec for handling resource in prometheus exporters:

In SDK Prometheus (pull) exporters, resource attributes SHOULD be converted to a single target_info metric; otherwise, they MUST be dropped, and MUST NOT be attached as labels to other metric families. The target_info metric MUST be an info-typed metric whose labels MUST include the resource attributes, and MUST NOT include any other labels. There MUST be at most one target_info metric exposed on an SDK Prometheus endpoint.

The Prometheus exporter currently doesn't use resource attributes for anything.

@lalitb lalitb added area:exporter:prometheus Prometheus Exporter area:metrics OpenTelemetry metrics labels Dec 5, 2022
@esigo esigo self-assigned this Dec 5, 2022
@dashpole dashpole changed the title Prometheus exporter emits target_info for Resource Prometheus exporter emits target_info metric using Resource Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

This issue was marked as stale due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:exporter:prometheus Prometheus Exporter area:metrics OpenTelemetry metrics do-not-stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants