Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Elasticsearch Log Exporter to use Synchronous HTTP methods #484

Closed
MarkSeufert opened this issue Dec 23, 2020 · 1 comment
Closed
Assignees

Comments

@MarkSeufert
Copy link
Contributor

Is your feature request related to a problem?
The Elasticsearch exporter currently uses asynchronous http requests to communicate with the Elasticsearch instance, where the error and response of the request is received through callback methods. Since the Export() method needs wait for the result of the http request, it has to block until the response is received.

Describe the solution you'd like
Using synchronous http requests will simplify the design of the exporter, since there will no longer be a need for the callback methods. Instead, the http request call would look something like:
auto response = session->SendRequestSync();

Additional context
The synchronous functionality is being added in PR #448, which needs to be merged before this issue can be worked on.

cc - @alolita @xukaren

@lalitb lalitb self-assigned this Jan 27, 2021
@lalitb
Copy link
Member

lalitb commented Jun 29, 2021

This can be closed for now. Async http requests are the right approach, as this allows to Cancel/Abort the request as needed.

@lalitb lalitb closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants