Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent test failure: 179 - trace.CircularBufferTest.Simulation (Failed) #841

Closed
maxgolov opened this issue Jun 8, 2021 · 2 comments · Fixed by #931
Closed

Intermittent test failure: 179 - trace.CircularBufferTest.Simulation (Failed) #841

maxgolov opened this issue Jun 8, 2021 · 2 comments · Fixed by #931
Labels
bug Something isn't working build and test
Milestone

Comments

@maxgolov
Copy link
Contributor

maxgolov commented Jun 8, 2021

This test is occasionally failing in CI.

Example run with the failure:
https://github.com/open-telemetry/opentelemetry-cpp/runs/2778747475

image

@ThomsonTan
Copy link
Contributor

With PR #796, more information on the test failure was included in the output as below, but seems the difference of the arrays is in the ... part, sigh. But it does show that there is a race condition in the circular buffer.

/home/runner/work/opentelemetry-cpp/opentelemetry-cpp/sdk/test/common/circular_buffer_test.cc:158: Failure
Expected equality of these values:
  producer_numbers
    Which is: { 20462, 39215, 229725, 291755, 674915, 718234, 909998, 1150462, 1530501, 1569515, 1671718, 1872383, 1932766, 2076752, 2142344, 2164891, 2220685, 2292977, 2321066, 2329286, 2347442, 2400544, 2525088, 2695210, 2754107, 2782193, 2984922, 2988760, 3005971, 3321013, 3433521, 3595424, ... }
  consumer_numbers
    Which is: { 20462, 39215, 229725, 291755, 674915, 718234, 909998, 1150462, 1530501, 1569515, 1671718, 1872383, 1932766, 2076752, 2142344, 2164891, 2220685, 2292977, 2321066, 2329286, 2347442, 2400544, 2525088, 2695210, 2754107, 2782193, 2984922, 2988760, 3005971, 3321013, 3433521, 3595424, ... }
[  FAILED  ] CircularBufferTest.Simulation (924 ms)

@lalitb
Copy link
Member

lalitb commented Jun 10, 2021

but seems the difference of the arrays is in the ... part

Murphy's law - the most important debug data never get's logged :)

It seems googletest PrintValue function for the container only prints the first 32 elements. To print all the elements, we need to define the printTo function for container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build and test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants