From 48c159a78e0a4fa64f47ac56a2bf5701adfaaafb Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Thu, 14 Apr 2022 10:15:53 -0700 Subject: [PATCH 1/2] Replace deprecated googletest API --- sdk/test/metrics/sync_metric_storage_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/test/metrics/sync_metric_storage_test.cc b/sdk/test/metrics/sync_metric_storage_test.cc index b0440fdbb3..1988fb6d3b 100644 --- a/sdk/test/metrics/sync_metric_storage_test.cc +++ b/sdk/test/metrics/sync_metric_storage_test.cc @@ -130,7 +130,7 @@ TEST_P(WritableMetricStorageTestFixture, LongSumAggregation) return true; }); } -INSTANTIATE_TEST_CASE_P(WritableMetricStorageTestLong, +INSTANTIATE_TEST_SUITE_P(WritableMetricStorageTestLong, WritableMetricStorageTestFixture, ::testing::Values(AggregationTemporality::kCumulative, AggregationTemporality::kDelta)); @@ -238,7 +238,7 @@ TEST_P(WritableMetricStorageTestFixture, DoubleSumAggregation) return true; }); } -INSTANTIATE_TEST_CASE_P(WritableMetricStorageTestDouble, +INSTANTIATE_TEST_SUITE_P(WritableMetricStorageTestDouble, WritableMetricStorageTestFixture, ::testing::Values(AggregationTemporality::kCumulative, AggregationTemporality::kDelta)); From 8d3db213c346c00e4c221dc4788558331537fd93 Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Thu, 14 Apr 2022 10:31:55 -0700 Subject: [PATCH 2/2] Fix format --- sdk/test/metrics/sync_metric_storage_test.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sdk/test/metrics/sync_metric_storage_test.cc b/sdk/test/metrics/sync_metric_storage_test.cc index 1988fb6d3b..7dfc4f9475 100644 --- a/sdk/test/metrics/sync_metric_storage_test.cc +++ b/sdk/test/metrics/sync_metric_storage_test.cc @@ -131,9 +131,9 @@ TEST_P(WritableMetricStorageTestFixture, LongSumAggregation) }); } INSTANTIATE_TEST_SUITE_P(WritableMetricStorageTestLong, - WritableMetricStorageTestFixture, - ::testing::Values(AggregationTemporality::kCumulative, - AggregationTemporality::kDelta)); + WritableMetricStorageTestFixture, + ::testing::Values(AggregationTemporality::kCumulative, + AggregationTemporality::kDelta)); TEST_P(WritableMetricStorageTestFixture, DoubleSumAggregation) { @@ -239,8 +239,8 @@ TEST_P(WritableMetricStorageTestFixture, DoubleSumAggregation) }); } INSTANTIATE_TEST_SUITE_P(WritableMetricStorageTestDouble, - WritableMetricStorageTestFixture, - ::testing::Values(AggregationTemporality::kCumulative, - AggregationTemporality::kDelta)); + WritableMetricStorageTestFixture, + ::testing::Values(AggregationTemporality::kCumulative, + AggregationTemporality::kDelta)); #endif