Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] - instrumentation-fs creates unecessary noise #1468

Closed
puckpuck opened this issue Mar 19, 2024 · 1 comment · Fixed by #1473
Closed

[frontend] - instrumentation-fs creates unecessary noise #1468

puckpuck opened this issue Mar 19, 2024 · 1 comment · Fixed by #1473
Labels
bug Something isn't working

Comments

@puckpuck
Copy link
Contributor

Seeing the visualizations in discussion #1453, we have plenty of spans related to instrumentation-fs which is called because the node process is loading up files for the first time. We should disable this instrumentation library completely to prevent the spans from being created and producing unnecessary noise on application startup.

@puckpuck puckpuck added the bug Something isn't working label Mar 19, 2024
@puckpuck
Copy link
Contributor Author

After investigating, we are getting an fs-stat and fs-open span for several of the GET calls for frontend resources, which were all called because we now load the app using a playwright load generator instead of just hitting the API calls directly like before. This is instrumentation noise that may be better to be left off. I'm going to submit a PR disabling the instrumentation-fs library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant