-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] add license lint check #233
Comments
Is there an equivalent of this in the dotnet repo @reyang ? |
Nope, I guess the model is different. OpenTelemetry .NET does not redistribute any source or binary. |
@bogdandrutu or @tigrannajaryan do y’all have suggestions or guidance on how the collector repo handles licensing checks & general licensing? We could use some help maturing our story here |
@fatsheep9146 all the need or updated services should have basic license info in one place now. I did a v1 review. We could potentially add this now or decide we don’t need it? |
Feature Request
I think the repo missing license lint check.
I submit a pr with a new but without license info, all checks are passed
a14ac25
Describe the solution you'd like:
What do you want to happen instead? What is the expected behavior?
Throw out check failed for pull request, just like the collector repo does
https://github.com/open-telemetry/opentelemetry-collector/blob/74cca75ee1b84b8da72b73122984b52b7857489f/.github/workflows/build-and-test.yml#L79-L80
The text was updated successfully, but these errors were encountered: