Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable OpenTelemetry Instrumentation #650

Open
svrnm opened this issue Dec 21, 2022 · 2 comments
Open

Make it possible to disable OpenTelemetry Instrumentation #650

svrnm opened this issue Dec 21, 2022 · 2 comments
Labels
enhancement New feature or request telemetry issues that relate to the telemetry generated by the demo

Comments

@svrnm
Copy link
Member

svrnm commented Dec 21, 2022

Feature Request

Is your feature request related to a problem?

#589, #606 and some other issues ask for the capability to autoinstrument services, especially by using the otel operator which comes with the capability to inject Automatic Instrumentation. While creating new services which are then auto instrumented is a possibility, I'd like to propose another solution:

By making it possibile to disable manual OpenTelemetry instrumentation, it would be possible to apply injected automatic instrumentation via the operator instead.

This not only removes the need to add even more services, it also allows has a few other benefits:

  • You could "gradually" instrument your application and see how a full picture builds, or you could leave a certain service un-instrumented on purpose to see what information you still get from an upstream service.
  • from a vendor perspective I could use my existing APM agents instead and have a way to compare what I see with OpenTelemetry and what I see with my existing solution.

Describe the solution you'd like:

My naive assumption is that this might be fairly easy to implement:

  • Add an environment variable like OTEL_DO_NOT_INSTRUMENT="true"
  • In the code of a service, put the SDK initalisation into a condiational block that checks for the value of that (if(!env.OTEL_DO_NOT_INSTRUMENT) { intializeSDK(); })
@svrnm svrnm added the enhancement New feature or request label Dec 21, 2022
@svrnm
Copy link
Member Author

svrnm commented Jan 9, 2023

follow up on this, I have played around with this in this branch:

@Flarna
Copy link
Member

Flarna commented Jan 10, 2023

This seems like a bug in the node.js sample.

@austinlparker austinlparker added v1.4 telemetry issues that relate to the telemetry generated by the demo labels Feb 6, 2023
@cartersocha cartersocha removed the v1.4 label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request telemetry issues that relate to the telemetry generated by the demo
Projects
None yet
Development

No branches or pull requests

4 participants