-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CurrencyService] Add C++ Metrics #759
[CurrencyService] Add C++ Metrics #759
Conversation
@lalitb would you mind taking a look at this one? |
Could you open and link a pr to the website docs adding this as a user created metric ? |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for enabling C++ metrics in demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! This runs fine.
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
Changes
This PR adds the manual metric
app_currency_counter
to the currency service.The metric counts how many times a specific currency was converted.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.