Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up OTEL_EXPORTER_OTLP_(*_)ENDPOINT environment variables #773

Closed
puckpuck opened this issue Mar 7, 2023 · 0 comments · Fixed by #809
Closed

Clean up OTEL_EXPORTER_OTLP_(*_)ENDPOINT environment variables #773

puckpuck opened this issue Mar 7, 2023 · 0 comments · Fixed by #809
Labels
enhancement New feature or request

Comments

@puckpuck
Copy link
Contributor

puckpuck commented Mar 7, 2023

Per the specification for the OTEL_EXPORTER_OTLP_ENDPOINT and we should not set the path when used (i.e.: /v1/traces). If setting the path, this needs to be done with the telemetry-specific variable i.e.: OTEL_EXPORTER_OTLP_TRACES_ENDPOINT. Some SDKs or use cases require the use of telemetry-specific variables. When that is the case, the generic one should not be included in that service's container.

The telemetry-specific environment variables are used in nearly all services, but the default value specified in the .env file is without the path specified, violating the specification. A few services do override the default and specify the path. We should make the path part of the defaults in .env.

The frontend demo component (perhaps others) specifies both the telemetry-specific and the non-telemetry-specific environment variables. This should be cleaned up as well.

@puckpuck puckpuck added enhancement New feature or request v1.4 labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant