From a71de53c31defeda700fe6cf91ba7a05a0b457c6 Mon Sep 17 00:00:00 2001
From: Cijo Thomas <cithomas@microsoft.com>
Date: Tue, 30 Mar 2021 09:52:06 -0700
Subject: [PATCH 1/2] Add correction to Filter in AspNetCore instrumentation
 (#1929)

---
 src/OpenTelemetry.Instrumentation.AspNetCore/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md
index 5a4a5ec18c1..68e5e9b7a93 100644
--- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md
+++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md
@@ -86,7 +86,7 @@ services.AddOpenTelemetryTracing(
 It is important to note that this `Filter` option is specific to this
 instrumentation. OpenTelemetry has a concept of a
 [Sampler](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#sampling),
-and the `Filter` option does the filtering *before* the Sampler is invoked.
+and the `Filter` option does the filtering *after* the Sampler is invoked.
 
 ### Enrich
 

From 539a2cde54df752a81c0df15ce79b44eaccc1f81 Mon Sep 17 00:00:00 2001
From: Cijo Thomas <cithomas@microsoft.com>
Date: Tue, 30 Mar 2021 11:02:25 -0700
Subject: [PATCH 2/2] Add minor clarificying doc comments (#1948)

---
 src/OpenTelemetry/Trace/SamplingParameters.cs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/OpenTelemetry/Trace/SamplingParameters.cs b/src/OpenTelemetry/Trace/SamplingParameters.cs
index c8a3893cdb3..f3496692014 100644
--- a/src/OpenTelemetry/Trace/SamplingParameters.cs
+++ b/src/OpenTelemetry/Trace/SamplingParameters.cs
@@ -71,10 +71,15 @@ public SamplingParameters(
         /// <summary>
         /// Gets the kind of span/activity to be created.
         /// </summary>
+        /// <remarks>
+        /// For Activities created outside of ActivitySource,
+        /// the Kind will be the default (Internal).
+        /// </remarks>
         public ActivityKind Kind { get; }
 
         /// <summary>
         /// Gets the tags to be associated to the span/activity to be created.
+        /// These are the tags provided at the time of Activity creation.
         /// </summary>
         public IEnumerable<KeyValuePair<string, object>> Tags { get; }