Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivityExporter is called even if Activity.Recorded is false. #1558

Closed
cijothomas opened this issue Nov 17, 2020 · 0 comments · Fixed by #1574
Closed

ActivityExporter is called even if Activity.Recorded is false. #1558

cijothomas opened this issue Nov 17, 2020 · 0 comments · Fixed by #1574
Assignees
@utpilla
Labels
bug Something isn't working
Milestone
1.0.0-RC1

Comments

@cijothomas
Copy link
Member

if Activity.IsAllDataRequested = true, Processors are to be called. But Exporters are to be called only if Activity.Recorded is true as well.
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling

We currently call Exporter irrespective of Activity.Recorded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utpilla utpilla

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging a pull request may close this issue.

Added Activity.IsRecorded check for Export utpilla/opentelemetry-dotnet
2 participants
@cijothomas @utpilla