Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse priority for Resource.Merge #1712

Closed
cijothomas opened this issue Jan 20, 2021 · 2 comments · Fixed by #1728
Closed

Reverse priority for Resource.Merge #1712

cijothomas opened this issue Jan 20, 2021 · 2 comments · Fixed by #1728
Assignees
@Austin-Tan
Labels
enhancement New feature or request

Comments

@cijothomas
Copy link
Member

Spec reversed the order of priority. The incoming resource take precedence in case of collision.
https://github.com/open-telemetry/opentelemetry-specification/pull/1345/files
@cijothomas cijothomas added the enhancement New feature or request label Jan 20, 2021
@Austin-Tan
Copy link
Member

When referring to the two resources, using "old" and "updating" instead of "current" and "other", as they use in the spec.

@Austin-Tan
Copy link
Member

Actually keeping the phrasing "other" since it's used as the parameter name and is generally convention in methods passed an "other" object for comparison or manipulation.

@Austin-Tan Austin-Tan mentioned this issue Jan 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Austin-Tan Austin-Tan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resource merge precedence
2 participants
@cijothomas @Austin-Tan