Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagation in case of remote parent #3315

Closed
vishweshbankwar opened this issue May 31, 2022 · 0 comments · Fixed by #3329
Closed

Propagation in case of remote parent #3315

vishweshbankwar opened this issue May 31, 2022 · 0 comments · Fixed by #3329
Labels
enhancement New feature or request

Comments

@vishweshbankwar
Copy link
Member

vishweshbankwar commented May 31, 2022

Currently, TraceProviderSDK forces activity creation by returning PropagationOnly sampling result for root activities by checking
isRootSpan = traceId == default. However, in case of remote parent the traceId is not default (e.g. asp.net core request with traceparent) which will result in loss of context propagation if the sampling results in data drop.

Proposing to add isRemote check as well so that the incoming traceId can be propagated to next hop.

#3310 covers the unit test for the scenario. Will create a follow up PR of TracerProviderSDK changes.

@vishweshbankwar vishweshbankwar added the enhancement New feature or request label May 31, 2022
@vishweshbankwar vishweshbankwar changed the title Follow up on unit test for propagation in case of remote parent Propagation in case of remote parent Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant