You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, TraceProviderSDK forces activity creation by returning PropagationOnly sampling result for root activities by checking isRootSpan = traceId == default. However, in case of remote parent the traceId is not default (e.g. asp.net core request with traceparent) which will result in loss of context propagation if the sampling results in data drop.
Proposing to add isRemote check as well so that the incoming traceId can be propagated to next hop.
#3310 covers the unit test for the scenario. Will create a follow up PR of TracerProviderSDK changes.
The text was updated successfully, but these errors were encountered:
Currently, TraceProviderSDK forces activity creation by returning PropagationOnly sampling result for root activities by checking
isRootSpan = traceId == default. However, in case of remote parent the
traceId
is not default (e.g. asp.net core request with traceparent) which will result in loss of context propagation if the sampling results in data drop.Proposing to add
isRemote
check as well so that the incomingtraceId
can be propagated to next hop.#3310 covers the unit test for the scenario. Will create a follow up PR of TracerProviderSDK changes.
The text was updated successfully, but these errors were encountered: