Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.flavor is not following the spec for metrics in the OpenTelemetry.Instrumentation.AspNetCore #3363

Closed
xavirec opened this issue Jun 15, 2022 · 1 comment · Fixed by #3379
Closed

http.flavor is not following the spec for metrics in the OpenTelemetry.Instrumentation.AspNetCore #3363

xavirec opened this issue Jun 15, 2022 · 1 comment · Fixed by #3379
Labels
bug Something isn't working

Comments

@xavirec
Copy link

xavirec commented Jun 15, 2022

Bug Report

OpenTelemetry.Instrumentation.AspNetCore 1.0.0-rc9.4 Runtime version: net6.0

http.flavor is not following de specs for metrics

In the HttpInMetricsListener the value of the http.flavor is set to the value of the HttpContext.Request.Protocol which is either HTTP/1.1, HTTP/2, etc.

What is the expected behavior?
http.flavor should be the kind of HTTP protocol used: "1.0", "1.1", "2", "SPDY" or "QUIC".
@xavirec xavirec added the bug Something isn't working label Jun 15, 2022
@cijothomas
Copy link
Member

Thanks for reporting the issue.

Will fix this once #3372 is accepted.

@cijothomas cijothomas mentioned this issue Jun 17, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AspNetCore metrics to use correct value for http.flavor cijothomas/opentelemetry-dotnet
2 participants
@xavirec @cijothomas