Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Fix a couple issues in automation workflows/scripts #5680

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

CodeBlanch
Copy link
Member

Changes

  • Don't require OPENTELEMETRYBOT_GITHUB_TOKEN secret in automation.yml. It is designed to work without it but because it is required all workflows which use automation blow up when run on forks if they don't have the secret defined.

  • Use proper PowerShell envvar syntax in post-release.psm1.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label Jun 7, 2024
@CodeBlanch CodeBlanch requested a review from a team June 7, 2024 20:16
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (6250307) to head (e9542b0).
Report is 253 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5680      +/-   ##
==========================================
+ Coverage   83.38%   86.05%   +2.67%     
==========================================
  Files         297      254      -43     
  Lines       12531    11054    -1477     
==========================================
- Hits        10449     9513     -936     
+ Misses       2082     1541     -541     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 85.98% <ø> (?)
unittests-Project-Stable 85.98% <ø> (?)
unittests-Solution 86.03% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 20.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 126 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit fd18bb1 into open-telemetry:main Jun 7, 2024
50 checks passed
@CodeBlanch CodeBlanch deleted the repo-automation-fixes branch June 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants