Remove View public API to change aggregation as it is not supported #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2660 +/- ##
==========================================
+ Coverage 81.31% 81.35% +0.04%
==========================================
Files 247 247
Lines 8670 8664 -6
==========================================
- Hits 7050 7049 -1
+ Misses 1620 1615 -5
|
reyang
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #2618 is not implemented yet, hiding the feature from public API itself. An alternate option was to throw NotImplementedException, but adding new public fields is not breaking, so can be introduced when #2618 is added.