bump minimum go version to 1.19 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dependencies require go 1.19+ https://github.com/open-telemetry/opentelemetry-go-build-tools/actions/runs/4205777490/jobs/7298348033 Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov ReportBase: 58.83% // Head: 58.83% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 58.83% 58.83%
=======================================
Files 44 44
Lines 1992 1992
=======================================
Hits 1172 1172
Misses 690 690
Partials 130 130 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Can we bump this to 1.20 instead? Guessing most devs are working with the latest release of Go, and by keeping the CI system using the latest it helps support that development. We recently did this for open-telemetry/opentelemetry-go#3733. I guess the difference there is we also have compatibility checks, but I'm not sure that matters too much here. |
MrAlias
approved these changes
Feb 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dependencies require go 1.19+ https://github.com/open-telemetry/opentelemetry-go-build-tools/actions/runs/4205777490/jobs/7298348033