Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a resource detector that sets a default value for service.instance.id according to semantic conventions #5423

Closed
pyohannes opened this issue Apr 23, 2024 · 3 comments · Fixed by open-telemetry/opentelemetry-go#5520
Assignees
Milestone

Comments

@pyohannes
Copy link
Contributor

Problem Statement

Currently, there is no resource detector provided that populates service.instance.id as specified in semantic conventions.

Proposed Solution

A resource detector for service attributes should be provided which sets values according to experimental semantic conventions for services.

Alternatives

Setting service.instance.id manually and ensuring that it is unique for each service instance.

@dashpole
Copy link
Contributor

If this eventually is moved to stable, it will become part of the default resource detector. Could we instead make this a feature of the default detector, similar to the defaultServiceNameDetector?

We could use environment variables to gate the feature, similar to other experimental parts of the SDK.

@MrAlias do you think we could move https://github.com/open-telemetry/opentelemetry-go/tree/main/sdk/metric/internal/x to sdk/internal/x so it can be used for non-metric SDK features?

@MrAlias
Copy link
Contributor

MrAlias commented Apr 23, 2024

@MrAlias do you think we could move https://github.com/open-telemetry/opentelemetry-go/tree/main/sdk/metric/internal/x to sdk/internal/x so it can be used for non-metric SDK features?

Yeah, we could add a similar package there. We wouldn't want to move it there as that would cross module boundaries. But we can implement the same thing there for other experimental features of that module.

@ayushrakesh
Copy link

@pyohannes Can you help me how to start work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment