Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelhttp still uses old semconv, resulting in exemplar label name "net.host.name" is invalid errors #6398

Closed
xsteadfastx opened this issue Dec 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@xsteadfastx
Copy link

Description

the otelhttp tracer throws me some errors in production code. i dont know if its just warnings or errors. but on tracing i get this

Dez 04 09:24:47 templeton hemingway[695]: 2024/12/04 09:24:47 exemplar label name "net.protocol.version" is invalid
Dez 04 09:24:47 templeton hemingway[695]: 2024/12/04 09:24:47 exemplar label name "net.protocol.version" is invalid
Dez 04 09:24:47 templeton hemingway[695]: 2024/12/04 09:24:47 exemplar label name "net.protocol.name" is invalid

i checked the code and saw that it semconvutil still depends on semconv version 1.20.0 which has net.protocol.version and so on as keys.

Environment

  • OS: linux
  • Architecture: amd64
  • Go Version: 1.23.3
  • go.opentelemetry.io/contrib version: v0.57.0

Expected behavior

using valid label names.

@xsteadfastx xsteadfastx added the bug Something isn't working label Dec 4, 2024
@dmathieu
Copy link
Member

dmathieu commented Dec 4, 2024

There are breaking changes between those semconv versions. So we can't just update them.
See this migration plan: #5132

Right now, setting the OTEL_SEMCONV_STABILITY_OPT_IN environment variable with a value of http/dup will duplicate the attributes so they match both semantic conventions.
Right now, if you don't specify this config, we still emit the 1.20.0 attributes. In the near future, the default behavior will change, and the default attributes will be on 1.26.0.

Closing this issue, as it's a migration we're already tracking.

@dmathieu dmathieu closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
@xsteadfastx
Copy link
Author

ok thanks for the info. added the env variable. i still get the

Dez 04 14:57:27 templeton hemingway[697]: 2024/12/04 14:57:27 exemplar label name "http.scheme" is invalid
Dez 04 14:57:27 templeton hemingway[697]: 2024/12/04 14:57:27 exemplar label name "net.host.name" is invalid
Dez 04 14:57:27 templeton hemingway[697]: 2024/12/04 14:57:27 exemplar label name "net.protocol.version" is invalid

this still should apperar right? because labels get duplicated.

@dmathieu
Copy link
Member

dmathieu commented Dec 4, 2024

Yes, this should still appear because the attributes are duplicated.

@xsteadfastx
Copy link
Author

thanks alot for your informations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants