Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate HTTP probes #101

Closed
2 tasks
MikeGoldsmith opened this issue Apr 26, 2023 · 1 comment
Closed
2 tasks

Consolidate HTTP probes #101

MikeGoldsmith opened this issue Apr 26, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@MikeGoldsmith
Copy link
Member

MikeGoldsmith commented Apr 26, 2023

Currently we have two HTTP based probes (net/http and gorilla) and a third to be added in #100. The probes are almost identical apart from the registration name and could be unified. The instrumentors would then deploy the unified probe instead of a custom version. Each probe is based on the net/http ServeHTTP(w ResponseWriter, r *Request) interface.

This would make probe maintenance easier by reducing code and would allow improvements to be applied generically instead. eg HTTP response parsing.

TODOs

@MrAlias
Copy link
Contributor

MrAlias commented Nov 21, 2024

This appears resolved. We currently only have one probe for HTTP (counting the client/server probes as one). Closing.

@MrAlias MrAlias closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants