Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for database/sql package #47

Closed
smitthakkar96 opened this issue Mar 25, 2023 · 4 comments
Closed

Feature Request: Add support for database/sql package #47

smitthakkar96 opened this issue Mar 25, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@smitthakkar96
Copy link

Is your feature request related to a problem? Please describe.
Automatically generate spans for calls to SQL databases

Describe the solution you'd like
Add a new instrumentor for datadbase/sql under https://github.com/open-telemetry/opentelemetry-go-instrumentation/tree/main/pkg/instrumentors/bpf

Describe alternatives you've considered
Manual Instrumentation

@smitthakkar96 smitthakkar96 added the enhancement New feature or request label Mar 25, 2023
@smitthakkar96
Copy link
Author

smitthakkar96 commented Mar 25, 2023

Is the community accepting contributions for packages other than http, grpc and mux? Is there any documentation or guidelines on how to extend this further? It would be awesome if we could automatically generate spans for popular open-source packages, such as the list under https://github.com/DataDog/dd-trace-go/tree/main/contrib. I am happy to contribute, would like to know how I can get involved in this project.

@pellared
Copy link
Member

Is there any documentation or guidelines on how to extend this further?

I suggest starting by getting familiar with both https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/main/docs/how-it-works.md and https://github.com/open-telemetry/opentelemetry-go-instrumentation/tree/main/docs/getting-started.

@pellared
Copy link
Member

I proposed to remove it from beta during last SIG meeting and nobody disagreed.

@MrAlias
Copy link
Contributor

MrAlias commented Aug 22, 2023

Closed by #240

@MrAlias MrAlias closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants