Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SpanContext to SpanReference #1256

Closed
MrAlias opened this issue Oct 14, 2020 · 4 comments
Closed

Rename SpanContext to SpanReference #1256

MrAlias opened this issue Oct 14, 2020 · 4 comments
Assignees
@cpackingham
Labels
area:trace Part of OpenTelemetry tracing help wanted Extra attention is needed pkg:API Related to an API package
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Oct 14, 2020

Update needed to track these changes: open-telemetry/opentelemetry-specification#1075
@MrAlias MrAlias added help wanted Extra attention is needed pkg:API Related to an API package area:trace Part of OpenTelemetry tracing release:required-for-ga labels Oct 14, 2020
@MrAlias MrAlias added this to the RC1 milestone Oct 14, 2020
@cpackingham
Copy link
Contributor

@MrAlias Mind if I take this one?

@cpackingham
Copy link
Contributor

cpackingham commented Oct 20, 2020 •
edited
Loading

Definitely going to need some extra eyes on the opentracing bridge and the exporters. Opentracing seems to have its own concepts of SpanReference and SpanContext so renaming is pretty dicey there - same with Zipkin. There are also Golang contexts.

@cpackingham cpackingham mentioned this issue Oct 20, 2020
Closed
4 tasks
@cpackingham
Copy link
Contributor

@MrAlias This issue should be closed - the decision to rename SpanContext was reverted in the spec: open-telemetry/opentelemetry-specification#1126

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 27, 2020

@cpackingham thank you for digging into this and sorry it ultimately was wasted time. 😞

@MrAlias MrAlias closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpackingham cpackingham

Labels
area:trace Part of OpenTelemetry tracing help wanted Extra attention is needed pkg:API Related to an API package
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Draft: Rename SpanContext to SpanReference cpackingham/opentelemetry-go
2 participants
@MrAlias @cpackingham