Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify compliant metric SDK specification implementation: MeterProvider/Aggregation/Drop Aggregation #3647

Closed
2 tasks done
Tracked by #3674
MrAlias opened this issue Feb 3, 2023 · 4 comments
Closed
2 tasks done
Tracked by #3674
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 3, 2023

  • Identify all the normative requirements, recommendations, and options the specification defines as comments to this issue
  • Ensure the current metric SDK implementation is compliant with these normative requirements, recommendations, and options in those comments.
@MrAlias MrAlias converted this from a draft issue Feb 3, 2023
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Feb 3, 2023
@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 1, 2023

The Drop Aggregation informs the SDK to ignore/drop all Instrument Measurements for this Aggregation.

This Aggregation does not have any configuration parameters.

This section has not normative statements.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 1, 2023

type Drop struct{} // Drop has no parameters.

Drop doesn't have any configuration parameters.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 1, 2023

Configuring a Drop aggregation will indeed drop measurements:

case aggregation.Drop:
return nil, nil

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 1, 2023

Done

@MrAlias MrAlias closed this as completed Jun 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Go: Metric SDK (GA) Jun 1, 2023
@MrAlias MrAlias self-assigned this Jun 1, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

No branches or pull requests

1 participant