Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify compliant metric SDK specification implementation: Instrument name #3654

Closed
2 tasks done
Tracked by #3674
MrAlias opened this issue Feb 3, 2023 · 3 comments
Closed
2 tasks done
Tracked by #3674

Verify compliant metric SDK specification implementation: Instrument name #3654

MrAlias opened this issue Feb 3, 2023 · 3 comments
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
v1.17.0/v0.40.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 3, 2023 •
edited
Loading

  • Identify all the normative requirements, recommendations, and options the specification defines as comments to this issue
  • Ensure the current metric SDK implementation is compliant with these normative requirements, recommendations, and options in those comments.
@MrAlias MrAlias converted this from a draft issue Feb 3, 2023
@MrAlias MrAlias mentioned this issue Feb 3, 2023
Closed
33 tasks
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Feb 3, 2023
@MrAlias MrAlias self-assigned this Jun 5, 2023
@MrAlias MrAlias moved this from Todo to In Progress in Go: Metric SDK (GA) Jun 5, 2023
@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 5, 2023

When a Meter creates an instrument, it SHOULD validate the instrument name conforms to the instrument name syntax

If the instrument name does not conform to this syntax, the Meter SHOULD emit an error notifying the user about the invalid name. It is left unspecified if a valid instrument is also returned.

As far as I can tell, this is not done in the SDK.

@MrAlias MrAlias mentioned this issue Jun 5, 2023
Closed
@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 5, 2023 •
edited
Loading

TODO:

@MrAlias MrAlias moved this from In Progress to Blocked in Go: Metric SDK (GA) Jun 5, 2023
@MrAlias MrAlias changed the title Verify compliant metric SDK specification implementation: Attribute limits Verify compliant metric SDK specification implementation: Instrument name Jun 5, 2023
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 11, 2023

All pending items complete. Closing.

@MrAlias MrAlias closed this as completed Jul 11, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Go: Metric SDK (GA) Jul 11, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
v1.17.0/v0.40.0
Development

No branches or pull requests
1 participant
@MrAlias