Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCensus bridge MUST support summaries #4571

Closed
dashpole opened this issue Sep 29, 2023 · 2 comments · Fixed by #4668
Closed

OpenCensus bridge MUST support summaries #4571

dashpole opened this issue Sep 29, 2023 · 2 comments · Fixed by #4668
Labels
bug Something isn't working pkg:bridges Related to a bridge package
Milestone
untracked

Comments

@dashpole
Copy link
Contributor

Description

https://github.com/open-telemetry/opentelemetry-specification/blob/v1.25.0/specification/compatibility/opencensus.md#requirements-1

MUST support Gauges, Counters, Cumulative Histograms, and Summaries

The bridge does not support summaries today:

https://github.com/open-telemetry/opentelemetry-go/blob/main/bridge/opencensus/internal/ocmetric/metric.go#L79

While it isn't unreasonable for us to add support for summaries, I'm not sure all SDKs should be required to support them. I'll open a specification issue for this before we implement it here.
@dashpole dashpole added bug Something isn't working pkg:bridges Related to a bridge package labels Sep 29, 2023
@dashpole dashpole mentioned this issue Sep 29, 2023
Closed
@dashpole
Copy link
Contributor Author

Blocked by open-telemetry/opentelemetry-specification#3708

@dashpole dashpole moved this from Todo to Blocked in Go: Metric OpenCensus Bridge (GA) Sep 29, 2023
@dashpole dashpole added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Sep 29, 2023
@dashpole dashpole mentioned this issue Oct 5, 2023
Closed
@dashpole dashpole moved this from Blocked to In Progress in Go: Metric OpenCensus Bridge (GA) Oct 13, 2023
@dashpole dashpole removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Oct 25, 2023
@dashpole
Copy link
Contributor Author

no longer blocked.

@dashpole dashpole mentioned this issue Oct 25, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric OpenCensus Bridge (GA) Nov 2, 2023
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pkg:bridges Related to a bridge package
Projects
No open projects
Go: Metric OpenCensus Bridge (GA)
Status: Done
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Add summary support in the OpenCensus bridge dashpole/opentelemetry-go
2 participants
@dashpole @XSAM