-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for instantiation of generic for type inference. #5511
Comments
dmathieu
changed the title
Check for instinaciation of generic for type inference.
Check for instanciation of generic for type inference.
Jun 17, 2024
From a quick grep, I'm finding only one non-test occurence.
opentelemetry-go/sdk/metric/view.go Lines 110 to 117 in 499785e
We could remove the generics in this method, by passing a third argument into the method which would be the zero value. |
MrAlias
changed the title
Check for instanciation of generic for type inference.
Check for instantiation of generic for type inference.
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @MadVikingGod in #5497 (comment)
This PR highlighted that this pattern of creating a Generic variable to make typer inferences is very costly. We should search to see if this pattern is used elsewhere and see if removing it gives us similar performance improvements.
The text was updated successfully, but these errors were encountered: