Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ToZipkinSpanModels for use outside this library #2027

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

coryb
Copy link
Contributor

@coryb coryb commented Jun 22, 2021

I recently started using OpenTelemetry and need to publish to an internal Zipkin compatible service without using the normal http service. There is a lot of useful code in this package for converting the spans I am hoping to be able to reuse this library rather than copy/paste it into my project.

Thanks for your consideration!

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 22, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #2027 (854b21f) into main (d5d4c87) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2027   +/-   ##
=====================================
  Coverage   72.7%   72.7%           
=====================================
  Files        164     164           
  Lines       8079    8079           
=====================================
+ Hits        5876    5880    +4     
+ Misses      1974    1972    -2     
+ Partials     229     227    -2     
Impacted Files Coverage Δ
exporters/zipkin/model.go 99.1% <ø> (ø)
exporters/zipkin/zipkin.go 70.1% <100.0%> (ø)
sdk/metric/sdk.go 81.3% <0.0%> (+1.1%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+22.2%) ⬆️

@Aneurysm9 Aneurysm9 added the blocked:CLA Waiting on CLA to be signed before progress can be made label Jun 22, 2021
exporters/zipkin/model.go Outdated Show resolved Hide resolved
@coryb coryb force-pushed the export-toZipkinSpanModels branch from aa06b68 to a2f0d2b Compare June 22, 2021 19:59
@MrAlias MrAlias removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Jun 22, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias requested a review from Aneurysm9 June 22, 2021 20:06
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@Aneurysm9 Aneurysm9 merged commit 16f83ce into open-telemetry:main Jun 23, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants