Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oteltest: ensure valid SpanContext created for span started WithNewRoot #2073

Merged
merged 3 commits into from
Jul 9, 2021

Conversation

Aneurysm9
Copy link
Member

Fixes #2071

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #2073 (15c45b5) into main (484258e) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2073     +/-   ##
=======================================
- Coverage   72.8%   72.8%   -0.1%     
=======================================
  Files        166     166             
  Lines       8168    8168             
=======================================
- Hits        5953    5949      -4     
- Misses      1985    1989      +4     
  Partials     230     230             
Impacted Files Coverage Δ
oteltest/tracer.go 89.6% <100.0%> (ø)
sdk/metric/sdk.go 80.2% <0.0%> (-2.4%) ⬇️

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to mention the fix in the changelog.

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@MrAlias MrAlias merged commit 12f737c into open-telemetry:main Jul 9, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oteltest.Tracer with trace.WithNewRoot() produces empty SpanContext
4 participants