Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct status transform in OTLP exporter #2102

Merged
merged 5 commits into from
Jul 20, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 19, 2021

Resolve #2099

@MrAlias MrAlias added the pkg:exporter:otlp Related to the OTLP exporter package label Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #2102 (265482c) into main (9b1a5f7) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2102   +/-   ##
=====================================
  Coverage   72.8%   72.8%           
=====================================
  Files        166     166           
  Lines       8185    8187    +2     
=====================================
+ Hits        5966    5968    +2     
  Misses      1989    1989           
  Partials     230     230           
Impacted Files Coverage Δ
...ers/otlp/otlptrace/internal/tracetransform/span.go 96.3% <100.0%> (+<0.1%) ⬆️

@MrAlias MrAlias marked this pull request as ready for review July 19, 2021 18:27
@bogdandrutu
Copy link
Member

I would leave #2098 open to hear more opinions from the community.

@MrAlias MrAlias merged commit 63dfe64 into open-telemetry:main Jul 20, 2021
@MrAlias MrAlias deleted the otlp-status-conv branch July 20, 2021 16:06
axw added a commit to axw/apm-server that referenced this pull request Sep 21, 2021
axw added a commit to elastic/apm-server that referenced this pull request Sep 21, 2021
mergify bot pushed a commit to elastic/apm-server that referenced this pull request Sep 21, 2021
Default span status changed to Unset: open-telemetry/opentelemetry-go#2102

(cherry picked from commit 117ca87)

# Conflicts:
#	systemtest/go.mod
#	systemtest/go.sum
axw added a commit to elastic/apm-server that referenced this pull request Sep 23, 2021
* systemtest: update opentelemetry-go (#6124)

Default span status changed to Unset: open-telemetry/opentelemetry-go#2102

(cherry picked from commit 117ca87)

# Conflicts:
#	systemtest/go.mod
#	systemtest/go.sum

* Fix merge conflicts, go mod tidy

Co-authored-by: Andrew Wilkins <axw@elastic.co>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP exporter should send unset status
5 participants