Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce values schema for the collector chart #135

Closed
dmitryax opened this issue Mar 4, 2022 · 3 comments
Closed

Introduce values schema for the collector chart #135

dmitryax opened this issue Mar 4, 2022 · 3 comments
Assignees
Labels
chart:collector Issue related to opentelemetry-collector helm chart

Comments

@dmitryax
Copy link
Member

dmitryax commented Mar 4, 2022

Introduce values.schema.json for values.yaml input validation in opentelemetry-collector helm chart. All the objects in values.yaml with predefined set of properties should not allow unknown properties.

This is a preliminary step for any big change to the helm chart configuration, e.g. #91

The following schema can be used as a reference: https://github.com/signalfx/splunk-otel-collector-chart/blob/main/helm-charts/splunk-otel-collector/values.schema.json

@dmitryax dmitryax added the chart:collector Issue related to opentelemetry-collector helm chart label Mar 4, 2022
@TylerHelmuth
Copy link
Member

I can look at this.

@TylerHelmuth
Copy link
Member

There is a lot of schema to add. Will probably submit PRs in small chunks to make review easier since each bit of validation added is valid in itself.

@dmitryax
Copy link
Member Author

dmitryax commented Mar 4, 2022

There is a lot of schema to add. Will probably submit PRs in small chunks to make review easier since each bit of validation added is valid in itself.

Sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:collector Issue related to opentelemetry-collector helm chart
Projects
None yet
Development

No branches or pull requests

2 participants