Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update open-telemetry charts to reflect change in crd collector spec #296

Closed
moh-osman3 opened this issue Jul 29, 2022 · 4 comments
Closed
Labels
chart:operator Issue related to opentelemetry-operator helm chart

Comments

@moh-osman3
Copy link

Trying to run an HPA with a statefulset collector and got the following error when trying to specify a minReplica value

% helm upgrade lightstep ./collector_k8s -f ./collector_k8s/values.yaml -f ./collector_k8s/values-remote.yaml -n opentelemetry --install --create-namespace
Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(OpenTelemetryCollector.spec): unknown field "minReplicas" in io.opentelemetry.v1alpha1.OpenTelemetryCollector.spec

and then looked at https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-operator/crds/crd-opentelemetrycollector.yaml#L177 and it seems that minReplicas is actually missing

Can this be updated to reflect this open-telemetry/opentelemetry-operator@0232b80? Thanks!

@TylerHelmuth TylerHelmuth added the chart:operator Issue related to opentelemetry-operator helm chart label Jul 29, 2022
@TylerHelmuth
Copy link
Member

/cc @Allex1

@TylerHelmuth
Copy link
Member

@Allex1 did the bump to 0.56.0 fix this issue?

@Allex1
Copy link
Contributor

Allex1 commented Aug 4, 2022

@TylerHelmuth the minReplica field is present in the new CRD but I haven't tested .
Maybe @moh-osman3 can give it a go ?

@moh-osman3
Copy link
Author

moh-osman3 commented Aug 4, 2022

I applied the udpated CRD to my collector statefulset and confirmed that minReplicas is now recognized and works as expected. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:operator Issue related to opentelemetry-operator helm chart
Projects
None yet
Development

No branches or pull requests

3 participants