Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename methods attachJavaagentToCurrentJVM -> attachJavaagentToCurrentJvm #992

Closed
trask opened this issue Aug 3, 2023 · 0 comments · Fixed by #1077
Closed

Rename methods attachJavaagentToCurrentJVM -> attachJavaagentToCurrentJvm #992

trask opened this issue Aug 3, 2023 · 0 comments · Fixed by #1077

Comments

@trask
Copy link
Member

trask commented Aug 3, 2023

The opentelemetry-java and opentelemetry-java-instrumentation repos both have checkstyle rule that would have forced attachJavaagentToCurrentJvm, but we never set up checkstyle in this repo.

Errorprone now has this same check. For now I have suppressed the errorprone violations in #989, but I think we should probably go ahead and rename these public API methods.

and

cc @jeanbisutti

@trask trask changed the title Rename method attachJavaagentToCurrentJVM -> attachJavaagentToCurrentJvm Rename methods attachJavaagentToCurrentJVM -> attachJavaagentToCurrentJvm Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants