Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links based sample option to config #903

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Add links based sample option to config #903

merged 3 commits into from
Jun 16, 2023

Conversation

atshaw43
Copy link
Contributor

@atshaw43 atshaw43 commented Jun 1, 2023

Description:

We do not have the option to use the LinksBasedSampler in the config.
This adds the option "linksbased_parentbased_always_on".

Existing Issue(s):

Testing:

Unit test

Documentation:

Outstanding items:

@atshaw43 atshaw43 requested a review from a team June 1, 2023 16:46
@github-actions github-actions bot requested review from iNikem and trask June 1, 2023 16:46
@atshaw43 atshaw43 marked this pull request as draft June 5, 2023 21:23
@atshaw43 atshaw43 marked this pull request as ready for review June 6, 2023 15:53
@atshaw43
Copy link
Contributor Author

atshaw43 commented Jun 6, 2023

@iNikem @trask
Making sure you saw this.

@trask trask added this to the v1.27.0 milestone Jun 9, 2023
trask
trask approved these changes Jun 13, 2023
View reviewed changes
samplers/build.gradle.kts Outdated Show resolved Hide resolved
samplers/build.gradle.kts Outdated Show resolved Hide resolved
@trask
Copy link
Member

trask commented Jun 13, 2023

@atshaw43 we lost one of our component owners for this samplers component (#915), we try to have 2 component owners listed for each component, are you able to be a component owner for it (see #174 for some background on component owners)

atshaw43 and others added 2 commits June 15, 2023 15:16
@atshaw43 @trask
Update samplers/build.gradle.kts
7b468f6 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@atshaw43 @trask
Update samplers/build.gradle.kts
336d915 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@atshaw43
Copy link
Contributor Author

FYI we backend out the message field translation due to a change in direction.

@trask trask merged commit c4645f7 into open-telemetry:main Jun 16, 2023
@atshaw43 atshaw43 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@iNikem iNikem Awaiting requested review from iNikem

Assignees

@trask trask

@iNikem iNikem

Labels
None yet
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atshaw43 @trask @iNikem