diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientAttributesGetter.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcAttributesGetter.java similarity index 61% rename from instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientAttributesGetter.java rename to instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcAttributesGetter.java index 88aeee2654a0..49f5d47c2414 100644 --- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientAttributesGetter.java +++ b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcAttributesGetter.java @@ -5,11 +5,23 @@ package io.opentelemetry.instrumentation.api.instrumenter.rpc; +import javax.annotation.Nullable; + /** - * An interface for getting RPC client attributes. + * An interface for getting RPC attributes. * *

Instrumentation authors will create implementations of this interface for their specific * library/framework. It will be used by the {@link RpcClientAttributesExtractor} or {@link * RpcServerAttributesExtractor} to obtain the various RPC attributes in a type-generic way. */ -public interface RpcClientAttributesGetter extends RpcCommonAttributesGetter {} +public interface RpcAttributesGetter { + + @Nullable + String system(REQUEST request); + + @Nullable + String service(REQUEST request); + + @Nullable + String method(REQUEST request); +} diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientAttributesExtractor.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientAttributesExtractor.java index 4060b69e0181..a4641bea2b9d 100644 --- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientAttributesExtractor.java +++ b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientAttributesExtractor.java @@ -14,19 +14,19 @@ * href="https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/rpc.md">RPC * client attributes. * - *

This class delegates to a type-specific {@link RpcCommonAttributesGetter} for individual - * attribute extraction from request/response objects. + *

This class delegates to a type-specific {@link RpcAttributesGetter} for individual attribute + * extraction from request/response objects. */ public final class RpcClientAttributesExtractor extends RpcCommonAttributesExtractor implements SpanKeyProvider { /** Creates the RPC client attributes extractor. */ public static RpcClientAttributesExtractor create( - RpcClientAttributesGetter getter) { + RpcAttributesGetter getter) { return new RpcClientAttributesExtractor<>(getter); } - private RpcClientAttributesExtractor(RpcCommonAttributesGetter getter) { + private RpcClientAttributesExtractor(RpcAttributesGetter getter) { super(getter); } diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcCommonAttributesExtractor.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcCommonAttributesExtractor.java index 88cb28fbb4ec..2bd928478a7e 100644 --- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcCommonAttributesExtractor.java +++ b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcCommonAttributesExtractor.java @@ -14,9 +14,9 @@ abstract class RpcCommonAttributesExtractor implements AttributesExtractor { - private final RpcCommonAttributesGetter getter; + private final RpcAttributesGetter getter; - RpcCommonAttributesExtractor(RpcCommonAttributesGetter getter) { + RpcCommonAttributesExtractor(RpcAttributesGetter getter) { this.getter = getter; } diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcCommonAttributesGetter.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcCommonAttributesGetter.java deleted file mode 100644 index 9876510d953a..000000000000 --- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcCommonAttributesGetter.java +++ /dev/null @@ -1,21 +0,0 @@ -/* - * Copyright The OpenTelemetry Authors - * SPDX-License-Identifier: Apache-2.0 - */ - -package io.opentelemetry.instrumentation.api.instrumenter.rpc; - -import javax.annotation.Nullable; - -/** An interface for getting RPC attributes common to clients and servers. */ -public interface RpcCommonAttributesGetter { - - @Nullable - String system(REQUEST request); - - @Nullable - String service(REQUEST request); - - @Nullable - String method(REQUEST request); -} diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerAttributesExtractor.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerAttributesExtractor.java index 2d0005efda50..25f6ae282e4c 100644 --- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerAttributesExtractor.java +++ b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerAttributesExtractor.java @@ -10,19 +10,19 @@ * href="https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/rpc.md">RPC * server attributes. * - *

This class delegates to a type-specific {@link RpcCommonAttributesGetter} for individual - * attribute extraction from request/response objects. + *

This class delegates to a type-specific {@link RpcAttributesGetter} for individual attribute + * extraction from request/response objects. */ public final class RpcServerAttributesExtractor extends RpcCommonAttributesExtractor { /** Creates the RPC server attributes extractor. */ public static RpcServerAttributesExtractor create( - RpcServerAttributesGetter getter) { + RpcAttributesGetter getter) { return new RpcServerAttributesExtractor<>(getter); } - private RpcServerAttributesExtractor(RpcCommonAttributesGetter getter) { + private RpcServerAttributesExtractor(RpcAttributesGetter getter) { super(getter); } } diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerAttributesGetter.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerAttributesGetter.java deleted file mode 100644 index 1c8f7b8cbbcf..000000000000 --- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerAttributesGetter.java +++ /dev/null @@ -1,15 +0,0 @@ -/* - * Copyright The OpenTelemetry Authors - * SPDX-License-Identifier: Apache-2.0 - */ - -package io.opentelemetry.instrumentation.api.instrumenter.rpc; - -/** - * An interface for getting RPC server attributes. - * - *

Instrumentation authors will create implementations of this interface for their specific - * library/framework. It will be used by the {@link RpcClientAttributesExtractor} or {@link - * RpcServerAttributesExtractor} to obtain the various RPC attributes in a type-generic way. - */ -public interface RpcServerAttributesGetter extends RpcCommonAttributesGetter {} diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractor.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractor.java index 0f02c2a971c3..22f70437096b 100644 --- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractor.java +++ b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractor.java @@ -15,22 +15,13 @@ public final class RpcSpanNameExtractor implements SpanNameExtractor/}. */ public static SpanNameExtractor create( - RpcClientAttributesGetter getter) { - return new RpcSpanNameExtractor<>(getter); + RpcAttributesGetter attributesExtractor) { + return new RpcSpanNameExtractor<>(attributesExtractor); } - /** - * Returns a {@link SpanNameExtractor} that constructs the span name according to RPC semantic - * conventions: {@code /}. - */ - public static SpanNameExtractor create( - RpcServerAttributesGetter getter) { - return new RpcSpanNameExtractor<>(getter); - } - - private final RpcCommonAttributesGetter getter; + private final RpcAttributesGetter getter; - private RpcSpanNameExtractor(RpcCommonAttributesGetter getter) { + private RpcSpanNameExtractor(RpcAttributesGetter getter) { this.getter = getter; } diff --git a/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcAttributesExtractorTest.java b/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcAttributesExtractorTest.java index e79dcedf4872..b092b6bad876 100644 --- a/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcAttributesExtractorTest.java +++ b/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcAttributesExtractorTest.java @@ -19,10 +19,7 @@ class RpcAttributesExtractorTest { - enum TestGetter - implements - RpcClientAttributesGetter>, - RpcServerAttributesGetter> { + enum TestGetter implements RpcAttributesGetter> { INSTANCE; @Override diff --git a/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractorTest.java b/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractorTest.java index 50b035c0e1a7..9c12691c150a 100644 --- a/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractorTest.java +++ b/instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcSpanNameExtractorTest.java @@ -6,68 +6,49 @@ package io.opentelemetry.instrumentation.api.instrumenter.rpc; import static org.assertj.core.api.Assertions.assertThat; -import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; import io.opentelemetry.instrumentation.api.instrumenter.SpanNameExtractor; -import java.util.stream.Stream; +import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; -import org.junit.jupiter.api.extension.ExtensionContext; -import org.junit.jupiter.params.ParameterizedTest; -import org.junit.jupiter.params.provider.Arguments; -import org.junit.jupiter.params.provider.ArgumentsProvider; -import org.junit.jupiter.params.provider.ArgumentsSource; +import org.mockito.Mock; import org.mockito.junit.jupiter.MockitoExtension; @ExtendWith(MockitoExtension.class) class RpcSpanNameExtractorTest { - @ParameterizedTest - @ArgumentsSource(Args.class) - void normal( - RpcCommonAttributesGetter getter, SpanNameExtractor extractor) { + @Mock RpcAttributesGetter getter; + + @Test + void normal() { RpcRequest request = new RpcRequest(); when(getter.service(request)).thenReturn("my.Service"); when(getter.method(request)).thenReturn("Method"); + SpanNameExtractor extractor = RpcSpanNameExtractor.create(getter); assertThat(extractor.extract(request)).isEqualTo("my.Service/Method"); } - @ParameterizedTest - @ArgumentsSource(Args.class) - void serviceNull( - RpcCommonAttributesGetter getter, SpanNameExtractor extractor) { + @Test + void serviceNull() { RpcRequest request = new RpcRequest(); when(getter.method(request)).thenReturn("Method"); + SpanNameExtractor extractor = RpcSpanNameExtractor.create(getter); assertThat(extractor.extract(request)).isEqualTo("RPC request"); } - @ParameterizedTest - @ArgumentsSource(Args.class) - void methodNull( - RpcCommonAttributesGetter getter, SpanNameExtractor extractor) { + @Test + void methodNull() { RpcRequest request = new RpcRequest(); when(getter.service(request)).thenReturn("my.Service"); + SpanNameExtractor extractor = RpcSpanNameExtractor.create(getter); assertThat(extractor.extract(request)).isEqualTo("RPC request"); } - static final class Args implements ArgumentsProvider { - - @SuppressWarnings("unchecked") - @Override - public Stream provideArguments(ExtensionContext context) { - RpcServerAttributesGetter serverGetter = mock(RpcServerAttributesGetter.class); - RpcClientAttributesGetter clientGetter = mock(RpcClientAttributesGetter.class); - return Stream.of( - Arguments.of(serverGetter, RpcSpanNameExtractor.create(serverGetter)), - Arguments.of(clientGetter, RpcSpanNameExtractor.create(clientGetter))); - } - } - static class RpcRequest {} } diff --git a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboRpcAttributesGetter.java b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboRpcAttributesGetter.java index 9aa1da7757f2..664bc70f65cc 100644 --- a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboRpcAttributesGetter.java +++ b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboRpcAttributesGetter.java @@ -5,11 +5,9 @@ package io.opentelemetry.instrumentation.apachedubbo.v2_7; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesGetter; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcServerAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; -enum DubboRpcAttributesGetter - implements RpcClientAttributesGetter, RpcServerAttributesGetter { +enum DubboRpcAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override diff --git a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTracingBuilder.java b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTracingBuilder.java index 029f94358039..b8b6e68ba464 100644 --- a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTracingBuilder.java +++ b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTracingBuilder.java @@ -16,7 +16,6 @@ import io.opentelemetry.instrumentation.api.instrumenter.net.NetClientAttributesExtractor; import io.opentelemetry.instrumentation.api.instrumenter.net.NetServerAttributesExtractor; import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesExtractor; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesGetter; import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcServerAttributesExtractor; import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcSpanNameExtractor; import io.opentelemetry.semconv.trace.attributes.SemanticAttributes; @@ -58,7 +57,7 @@ public DubboTracingBuilder addAttributesExtractor( public DubboTracing build() { DubboRpcAttributesGetter rpcAttributesGetter = DubboRpcAttributesGetter.INSTANCE; SpanNameExtractor spanNameExtractor = - RpcSpanNameExtractor.create((RpcClientAttributesGetter) rpcAttributesGetter); + RpcSpanNameExtractor.create(rpcAttributesGetter); DubboNetClientAttributesGetter netClientAttributesGetter = new DubboNetClientAttributesGetter(); InstrumenterBuilder serverInstrumenterBuilder = diff --git a/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkRpcAttributesGetter.java b/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkRpcAttributesGetter.java index 573dea09444a..cb6ef41fda99 100644 --- a/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkRpcAttributesGetter.java +++ b/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkRpcAttributesGetter.java @@ -6,9 +6,9 @@ package io.opentelemetry.instrumentation.awssdk.v1_11; import com.amazonaws.Request; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; -enum AwsSdkRpcAttributesGetter implements RpcClientAttributesGetter> { +enum AwsSdkRpcAttributesGetter implements RpcAttributesGetter> { INSTANCE; private static final ClassValue OPERATION_NAME = diff --git a/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkRpcAttributesGetter.java b/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkRpcAttributesGetter.java index c72f58cc1fad..50fe74884156 100644 --- a/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkRpcAttributesGetter.java +++ b/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkRpcAttributesGetter.java @@ -5,11 +5,11 @@ package io.opentelemetry.instrumentation.awssdk.v2_2; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; import software.amazon.awssdk.core.interceptor.ExecutionAttributes; import software.amazon.awssdk.core.interceptor.SdkExecutionAttribute; -enum AwsSdkRpcAttributesGetter implements RpcClientAttributesGetter { +enum AwsSdkRpcAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override diff --git a/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcRpcAttributesGetter.java b/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcRpcAttributesGetter.java index 3ec6eab0b7df..4f1087ae83f2 100644 --- a/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcRpcAttributesGetter.java +++ b/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcRpcAttributesGetter.java @@ -5,12 +5,10 @@ package io.opentelemetry.instrumentation.grpc.v1_6; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesGetter; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcServerAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; import javax.annotation.Nullable; -enum GrpcRpcAttributesGetter - implements RpcClientAttributesGetter, RpcServerAttributesGetter { +enum GrpcRpcAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override diff --git a/instrumentation/gwt-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/gwt/GwtRpcAttributesGetter.java b/instrumentation/gwt-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/gwt/GwtRpcAttributesGetter.java index da4bf77a4a2a..342b31b4b279 100644 --- a/instrumentation/gwt-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/gwt/GwtRpcAttributesGetter.java +++ b/instrumentation/gwt-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/gwt/GwtRpcAttributesGetter.java @@ -5,10 +5,10 @@ package io.opentelemetry.javaagent.instrumentation.gwt; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcServerAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; import java.lang.reflect.Method; -enum GwtRpcAttributesGetter implements RpcServerAttributesGetter { +enum GwtRpcAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override diff --git a/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/client/RmiClientAttributesGetter.java b/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/client/RmiClientAttributesGetter.java index 99b40a494921..5480ed71aa5c 100644 --- a/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/client/RmiClientAttributesGetter.java +++ b/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/client/RmiClientAttributesGetter.java @@ -5,10 +5,10 @@ package io.opentelemetry.javaagent.instrumentation.rmi.client; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; import java.lang.reflect.Method; -enum RmiClientAttributesGetter implements RpcClientAttributesGetter { +enum RmiClientAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override diff --git a/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/server/RmiServerAttributesGetter.java b/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/server/RmiServerAttributesGetter.java index 7f8f5b37046d..3aea7bb481b6 100644 --- a/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/server/RmiServerAttributesGetter.java +++ b/instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/server/RmiServerAttributesGetter.java @@ -5,10 +5,10 @@ package io.opentelemetry.javaagent.instrumentation.rmi.server; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcServerAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; import io.opentelemetry.instrumentation.api.util.ClassAndMethod; -enum RmiServerAttributesGetter implements RpcServerAttributesGetter { +enum RmiServerAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override diff --git a/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientAttributesGetter.java b/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientAttributesGetter.java index c6b17256527a..84ebd2e57548 100644 --- a/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientAttributesGetter.java +++ b/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientAttributesGetter.java @@ -5,10 +5,10 @@ package io.opentelemetry.javaagent.instrumentation.springrmi.client; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcClientAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; import java.lang.reflect.Method; -public enum ClientAttributesGetter implements RpcClientAttributesGetter { +public enum ClientAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override diff --git a/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/server/ServerAttributesGetter.java b/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/server/ServerAttributesGetter.java index 2a65cbd14108..9e55688b0dda 100644 --- a/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/server/ServerAttributesGetter.java +++ b/instrumentation/spring/spring-rmi-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/springrmi/server/ServerAttributesGetter.java @@ -5,10 +5,10 @@ package io.opentelemetry.javaagent.instrumentation.springrmi.server; -import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcServerAttributesGetter; +import io.opentelemetry.instrumentation.api.instrumenter.rpc.RpcAttributesGetter; import io.opentelemetry.instrumentation.api.util.ClassAndMethod; -public enum ServerAttributesGetter implements RpcServerAttributesGetter { +public enum ServerAttributesGetter implements RpcAttributesGetter { INSTANCE; @Override