Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge more incubating api #12230

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Bridge more incubating api #12230

merged 1 commit into from
Sep 24, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Sep 12, 2024 •
edited
Loading

Resolves #12128
Adds bridging for isEnabled in tracer, logger and meter implementations and for ExtendedSpanBuilder.

@laurit laurit requested a review from a team September 12, 2024 14:13
zeitlinger
zeitlinger approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

I'm wondering if we need a code generator for this at some point (or another idea to keep this manageable)

...entelemetry/javaagent/instrumentation/opentelemetryapi/v1_40/incubator/trace/TracerTest.java Show resolved Hide resolved
@laurit laurit merged commit d3068c8 into open-telemetry:main Sep 24, 2024
56 checks passed
@laurit laurit deleted the bridge-incubating-api branch September 24, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitlinger zeitlinger zeitlinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incubating OTel APIs can't be used it the agent
2 participants
@laurit @zeitlinger