Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original license headers are missing for context package. #1820

Closed
Oberon00 opened this issue Oct 16, 2020 · 3 comments · Fixed by #1828
Closed

Original license headers are missing for context package. #1820

Oberon00 opened this issue Oct 16, 2020 · 3 comments · Fixed by #1828
Labels
API API related issues Bug Something isn't working priority:p1 Critical issues and bugs. Highest priority; breaking API changes. release:required-for-ga Required for 1.0 GA release

Comments

@Oberon00
Copy link
Member

Oberon00 commented Oct 16, 2020

In the PR description of #1658:

The API is heavily inspired by gRPC and Armeria. Much code / docs are borrowed too and I kept license headers in tact to reflect that.

which is sensible and actually required by the OTel/CNCF policy:

According to CNCF recommendations if you are contributing third-party code you will need to retain the original copyright notice.

-- https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md#copyright-notices

However, the statement from the PR description is unfortunately, wrong there is only the OTel license. Maybe the original license header got killed by spotlessApply.

CC @anuraaga

@Oberon00 Oberon00 added the Bug Something isn't working label Oct 16, 2020
@Oberon00 Oberon00 changed the title Originial license headers are missing for context package. Original license headers are missing for context package. Oct 16, 2020
@Oberon00
Copy link
Member Author

As it is now, e.g. the PersistentHashArrayMappedTrie.java file has no indication whatsoever that it is a 1:1 copy & paste from grpc-context. Knowing that would have eased my mind about the battle-testedness of this rather complicated code considerably 😃

@jkwatson jkwatson added priority:p1 Critical issues and bugs. Highest priority; breaking API changes. release:required-for-ga Required for 1.0 GA release labels Oct 16, 2020
@jkwatson jkwatson added the API API related issues label Oct 16, 2020
@iNikem
Copy link
Contributor

iNikem commented Oct 19, 2020

Spotless should be taught to accept two licenses in the same file. I think it has problems with that atm. Both here and in the instrumentation repository.

@anuraaga
Copy link
Contributor

@iNikem I came up with a workaround for it but think I didn't merge that into the branch, let me show it in a bit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Bug Something isn't working priority:p1 Critical issues and bugs. Highest priority; breaking API changes. release:required-for-ga Required for 1.0 GA release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants