Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Span Attributes: http.url must not contain username / password #3118

Closed
pellared opened this issue Apr 6, 2021 · 0 comments · Fixed by #3121
Closed

HTTP Span Attributes: http.url must not contain username / password #3118

pellared opened this issue Apr 6, 2021 · 0 comments · Fixed by #3121
Labels
Feature Request Suggest an idea for this project

Comments

@pellared
Copy link
Member

pellared commented Apr 6, 2021 •
edited
Loading

Why

As is stated in the recent specification change :

http.url MUST NOT contain credentials passed via URL in form of https://username:password@www.example.com/. In such case the attribute's value should be https://www.example.com/

What

This example could be reviewed (and fixed) to make sure that others do not copy-paste potentially unsafe code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove credential info from url in example Hangzhi/opentelemetry-java
1 participant
@pellared